Homec4science

Allow Herald "diff" rules to reject content before it is written

Authored by epriestley <git@epriestley.com> on Aug 20 2014, 23:26.

Description

Allow Herald "diff" rules to reject content before it is written

Summary: Fixes T5915. Occasionally, users derp up and diff private key material. Adding a pre-write Herald phase enables configuration of a partial layer of protection that will reject these changes before they hit disk, provided they can be detected by, e.g., filename.

Test Plan:

  • Added a rule with checks on every field, verified they looked fine in the transcript.
  • Created some revisions to test those changes (I have a bunch of revision rules locally).
  • Verified rejects don't write transcripts to the database.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5915

Differential Revision: https://secure.phabricator.com/D10305

Details

Committed
epriestley <git@epriestley.com>Aug 20 2014, 23:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPH15385e1fe9b5: Don't SIGINT ourselves on bad daemon data
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5ac36e8f77ee: Allow Herald "diff" rules to reject content before it is written (authored by epriestley <git@epriestley.com>).Aug 20 2014, 23:26