Homec4science

Fix some CC handling in Maniphest

Authored by epriestley <git@epriestley.com> on Jan 12 2015, 02:57.

Description

Fix some CC handling in Maniphest

Summary:
Fixes T6932. Fixes some issues from D11303.

  • When claiming a task, if it was previously unassigned, we would try to CC null.
  • When claiming a task, if the current owner was already CC'd, the viewer would incorrectly be warned about all subscribers being CC'd.

Test Plan:

  • Claimed an unclaimed task.
  • Claimed a task with owner CC'd.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6932

Differential Revision: https://secure.phabricator.com/D11336

Details

Committed
epriestley <git@epriestley.com>Jan 12 2015, 02:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPH698b7f9ea39c: Explicitly declare method/property visibility
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5b3b9b7182ae: Fix some CC handling in Maniphest (authored by epriestley <git@epriestley.com>).Jan 12 2015, 02:57