Homec4science

Write fewer "applied" rows and clean up excess historical rows

Authored by epriestley <git@epriestley.com> on Jan 25 2012, 20:53.

Description

Write fewer "applied" rows and clean up excess historical rows

Summary:

  • Only write the <ruleID, phid> row if the rule is a one-time rule.
  • Delete all the rows for rules which aren't one-time.
NOTE: This is probably like several million rows for Facebook and could take a while.

Test Plan:
Added some one-time and every-time rules, ran them against objects, verified
only relevant rows were inserted.
Ran upgrade script against a database with one-time and every-time "ruleapplied"
rows, got the irrelevant rows removed.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1484

Details

Committed
epriestley <git@epriestley.com>Jan 25 2012, 20:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcb0bb8165d83: Add a Join / Leave button to Projects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5b463e634ccf: Write fewer "applied" rows and clean up excess historical rows (authored by epriestley <git@epriestley.com>).Jan 25 2012, 20:53