Homec4science

Provide a transaction editor to perform Audit row writes

Authored by epriestley <git@epriestley.com> on Aug 2 2014, 09:06.

Description

Provide a transaction editor to perform Audit row writes

Summary:
Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan:

  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4896

Differential Revision: https://secure.phabricator.com/D10109

Details

Committed
epriestley <git@epriestley.com>Aug 2 2014, 09:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH89b942c183eb: Move Audit to proper Subscriptions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5b969fb5b809: Provide a transaction editor to perform Audit row writes (authored by epriestley <git@epriestley.com>).Aug 2 2014, 09:06