Homec4science

Land Revision button for hosted git repos

Authored by Aviv Eyal <aeyal@groupon.com> on Nov 5 2013, 22:00.

Description

Land Revision button for hosted git repos

Summary:
ref T182.

Simple approach of clone, patch, push. While waiting for drydock, implement a hackish mutex
setup for the workspace, which should work ok as long as there's only one committer who is
carefull about theses things.

Less obvious note: This is taking the both author and commiter's 'primary email' for the commit -
which might rub some people wrong.

Test Plan:
With a hosted repo, created some diffs and landed them.
Also clicked button for some error cases, got the right error message.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: hach-que, Korvin, epriestley, aran

Maniphest Tasks: T182

Differential Revision: https://secure.phabricator.com/D7486

Details

Committed
epriestley <git@epriestley.com>Nov 5 2013, 22:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHca5400d14bcb: Implement basic Harbormaster daemon and start builds.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5c0edc935102: Land Revision button for hosted git repos (authored by Aviv Eyal <aeyal@groupon.com>).Nov 5 2013, 22:00