Homec4science

Use LiskDAOSet's loadRelativeEdges with ReleephRequest

Authored by Edward Speyer <edward@fb.com> on May 1 2013, 11:22.

Description

Use LiskDAOSet's loadRelativeEdges with ReleephRequest

Summary:
ReleephRequests contain the PHID for a PhabricatorRepositoryCommit, and commits have an edge to a DifferentialRevision.

Commits are loaded with the loadOneRelative() method that loads the commits for every ReleephRequest in a LiskDAOSet, but the edges are loaded indivdually. A page with N RQs on it makes one DB query for the commits, but N queries for the TYPE_COMMIT_HAS_DREV edges.

This diff uses loadRelativeEdges instead to load the edges all in one query.

Test Plan: {F42290}

Reviewers: wez, epriestley

Reviewed By: epriestley

CC: epriestley, vrana, aran

Maniphest Tasks: T2714

Differential Revision: https://secure.phabricator.com/D5820

Details

Committed
Edward Speyer <edward@fb.com>May 7 2013, 12:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH30b15e094c59: Load commits affected by revert language in Diffusion message parser
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPH5c4a9ac9e582: Use LiskDAOSet's loadRelativeEdges with ReleephRequest (authored by Edward Speyer <edward@fb.com>).May 7 2013, 12:05