Homec4science

Clean up some EditEngine policy issues

Authored by epriestley <git@epriestley.com> on Dec 7 2015, 19:34.

Description

Clean up some EditEngine policy issues

Summary:
Ref T9908.

  • You should not need edit permission on a task in order to comment on it.
  • At least for now, ignore any customization in Conduit and Stacked Actions. These UIs always use the full edit form as it's written in the application.

Test Plan:

  • Verified a non-editor can now comment on tasks they can see.
  • Verified a user still can't use an edit form they can't see.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9908

Differential Revision: https://secure.phabricator.com/D14691

Details

Committed
epriestley <git@epriestley.com>Dec 7 2015, 20:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPH20e6a4200dbc: Validate configuration of `maniphest.priorities`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5caee3521eaa: Clean up some EditEngine policy issues (authored by epriestley <git@epriestley.com>).Dec 7 2015, 20:13