Homec4science

Add background to haunted differential comment panel

Authored by Nick Harper <nharper@fb.com> on Dec 12 2012, 00:00.

Description

Add background to haunted differential comment panel

Summary:
Warning boxes in a haunted differential comment panel were showing up
without a background (so the contents below were showing through).
This adds the background.

Test Plan:
viewed haunted differential comment panel on a diff with lint errors
and selected "accept revision". Confirmed that the diff and sidebar did
not show through underneath the red warning box.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4154

Details

Committed
Nick Harper <nharper@fb.com>Dec 12 2012, 00:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbfc5bb7c7867: change DifferentialRevisionDetailView to use newer fangled UI abstractions
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH5cb0f477619d: Add background to haunted differential comment panel (authored by Nick Harper <nharper@fb.com>).Dec 12 2012, 00:00