Homec4science

Don't add author and reviewers to CCs

Authored by vrana <jakubv@fb.com> on Jan 14 2012, 07:22.

Description

Don't add author and reviewers to CCs

Summary:
Commenting on a diff causes adding the writer to the CCs. It doesn't make much
sense if the writer is author or reviewer who get all the copies anyway.

I've also moved the decision to DifferentialCommentEditor.

Test Plan:
Comment on a diff where I am author
Comment on a diff where I am reviewer
Comment on a diff where I am neither
Explicitely Add CCs where I am author

Reviewers: epriestley

Reviewed By: epriestley

CC: jungejason, aran, epriestley

Differential Revision: https://secure.phabricator.com/D1397

Details

Committed
vrana <jakubv@fb.com>Jan 14 2012, 20:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH95cde81daf13: Minor, reduce slug column size to 128, see D1391.
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH5cf6d788ced2: Don't add author and reviewers to CCs (authored by vrana <jakubv@fb.com>).Jan 14 2012, 20:10