Homec4science

Allow device SSH keys to be trusted

Authored by epriestley <git@epriestley.com> on Nov 21 2014, 02:33.

Description

Allow device SSH keys to be trusted

Summary:
Ref T6240. Some discussion in that task. In instance/cluster environments, daemons need to make Conduit calls that bypass policy checks.

We can't just let anyone add SSH keys with this capability to the web directly, because then an adminstrator could just add a key they own and start signing requests with it, bypassing policy checks.

Add a bin/almanac trust-key --id <x> workflow for trusting keys. Only trusted keys can sign requests.

Test Plan:

  • Generated a user key.
  • Generated a device key.
  • Trusted a device key.
  • Untrusted a device key.
  • Hit the various errors on trust/untrust.
  • Tried to edit a trusted key.

{F236010}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6240

Differential Revision: https://secure.phabricator.com/D10878

Details

Committed
epriestley <git@epriestley.com>Nov 21 2014, 02:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc2f0955e9bd2: Add workboard link to emails about workboard changes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5e0f218fe480: Allow device SSH keys to be trusted (authored by epriestley <git@epriestley.com>).Nov 21 2014, 02:33