Simplify some logic in project controllers
5e715c1acac0
Actions

Authored by epriestley <git@epriestley.com> on Dec 27 2015, 11:04.

Description

Simplify some logic in project controllers

Summary: Ref T10010. Several controlers currently have similar logic for handling tags and slugs, loading projects, and canonicalizing URIs. Clean it up a bit.

Test Plan:

Visited profile, boards, feed.
Visited by ID and by tag.
Visited by non-normal tag (redircted).
Visited by alternate tag (redirected).
Visited non-policy project by non-normal tag (redirected into policy error).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D14890

Details

Committed

epriestley <git@epriestley.com>

Dec 27 2015, 18:21

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHd1f1d3ec33bb: Implement a basic project.search third-generation API method

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5e715c1acac0: Simplify some logic in project controllers (authored by epriestley <git@epriestley.com>).Dec 27 2015, 18:21

Changes (5)

				Path
	M			src/applications/project/controller/PhabricatorProjectController.php
	M			src/applications/project/controller/PhabricatorProjectFeedController.php
	M			src/applications/project/controller/PhabricatorProjectMembersEditController.php
	M			src/applications/project/controller/PhabricatorProjectProfileController.php
	M			src/applications/project/controller/PhabricatorProjectViewController.php