Homec4science

Transactions - land buildTransactionTimeline in a bunch more apps

Authored by Bob Trahan <btrahan@phacility.com> on Dec 3 2014, 22:16.

Description

Transactions - land buildTransactionTimeline in a bunch more apps

Summary:
Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)

Test Plan: foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4712

Differential Revision: https://secure.phabricator.com/D10924

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 3 2014, 22:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc2522a89b9a2: Transactions - deploy buildTransactionTimeline against Config, Pholio, and…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH5e8600442d73: Transactions - land buildTransactionTimeline in a bunch more apps (authored by Bob Trahan <btrahan@phacility.com>).Dec 3 2014, 22:16