Homec4science

Make storage.mysql-engine.max-size independent on max_allowed_packet

Authored by vrana <jakubv@fb.com> on Aug 28 2012, 00:40.

Description

Make storage.mysql-engine.max-size independent on max_allowed_packet

Summary:
I like systems that just work. It is possible to store files larger than max_allowed_packet in MySQL and we shouldn't demand it.

It also fixes a problem when file was smaller than storage.mysql-engine.max-size but its escaped version was larger than max_allowed_packet.

Test Plan: Reduced the size to 5e4, uploaded 90 kB file, checked the queries in DarkConsole, downloaded the file.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3392

Details

Committed
vrana <jakubv@fb.com>Aug 28 2012, 00:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4efeb3c9774: Minor, fix an issue where recaptcha is included over HTTP on HTTPS installs and…
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH5f3dc3b7aecf: Make storage.mysql-engine.max-size independent on max_allowed_packet (authored by vrana <jakubv@fb.com>).Aug 28 2012, 00:56