Homec4science

Fix some off-by-one issues when drag-and-dropping dashboard panels

Authored by epriestley <git@epriestley.com> on Jun 16 2014, 18:15.

Description

Fix some off-by-one issues when drag-and-dropping dashboard panels

Summary: Fixes T5321. There were a couple of off-by-one issues here which could result in inserts into the wrong position.

Test Plan:

  • Dragged panels to the top, bottom, and first position of columns.
  • Dragged panels from one column to another.
  • Reloaded the page after drags, things stayed where I put them.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5321

Differential Revision: https://secure.phabricator.com/D9573

Details

Committed
epriestley <git@epriestley.com>Jun 16 2014, 18:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0efa1ca6430a: Make the Pholio download button actually download
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5f52f1f82cac: Fix some off-by-one issues when drag-and-dropping dashboard panels (authored by epriestley <git@epriestley.com>).Jun 16 2014, 18:15