Homec4science

Use some HTTPSFuture in CampfireBot

Authored by epriestley <git@epriestley.com> on Feb 7 2013, 19:32.

Description

Use some HTTPSFuture in CampfireBot

Summary:

  • Use PhutilURI to correct for specifying "https://yourname.campfire.com/" instead of "https://yourname.campfire.com".
  • Use HTTPSFuture to get logging via --trace and error detection (CA stuff should be OK since 37signals has real certs).
  • On destruction, only try to leave rooms we've actually joined.

Test Plan: Setup a bot, had it join a room, talked to it.

Reviewers: indiefan

Reviewed By: indiefan

CC: aran

Differential Revision: https://secure.phabricator.com/D4849

Details

Committed
epriestley <git@epriestley.com>Feb 7 2013, 19:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ce3f5d36803: Drafts are saved as inline comments for images when user comments mock
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5f9a06333356: Use some HTTPSFuture in CampfireBot (authored by epriestley <git@epriestley.com>).Feb 7 2013, 19:32