Homec4science

Make JX.Tooltip more conservative about positioning

Authored by epriestley <git@epriestley.com> on Jan 5 2017, 17:49.

Description

Make JX.Tooltip more conservative about positioning

Summary:
Fixes T10687. Fixes T12064.

  • Primarily, adds a margin around the edge of the screen for the purposes of aligning the tooltip.
  • Also, tries to flip the tooltip if it can (e.g., if the tooltip normally goes east, try west first), then tries other positions exhastively.

Test Plan:
{F2309363}

{F2309364}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12064, T10687

Differential Revision: https://secure.phabricator.com/D17145

Details

Committed
epriestley <git@epriestley.com>Jan 6 2017, 01:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1f2306999bb5: Fix a case where "Accept + Comment" would ignore the "Accept"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5ff02058a4b0: Make JX.Tooltip more conservative about positioning (authored by epriestley <git@epriestley.com>).Jan 6 2017, 01:03