Homec4science

Make the chatbot obey the object name blacklist

Authored by Josh Cox <joshcox@uberatc.com> on Aug 23 2016, 14:09.

Description

Make the chatbot obey the object name blacklist

Summary: Fixes T11508. The config entry remarkup.ignored-object-names already contains a blacklist of object names that should be ignored in the web UI. This change makes that blacklist also apply to the chatbot. This makes it possible to have a chatbot ignore things like V1, V2, Q1 and any other phrases the user may not want to generate links to objects.

Test Plan: Create objects (tasks, slowvotes, etc.) then mention the object names in chat (with the bot running). The bot should respond with helpful links to the given objects. Then add the object names to the blacklist through the config web UI. This apparently triggers the bot to restart itself. Then mention the object names in chat again. The bot should no longer respond with links because those object names have been added to the blacklist regex.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Maniphest Tasks: T11508

Differential Revision: https://secure.phabricator.com/D16442

Details

Committed
Josh Cox <joshcox@uberatc.com>Aug 23 2016, 14:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPHae0cf00a232f: Document the use of repository commit hints
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cox <joshcox@uberatc.com> committed rPH605210bc95af: Make the chatbot obey the object name blacklist (authored by Josh Cox <joshcox@uberatc.com>).Aug 23 2016, 14:38