Homec4science

Write separate comments for every action in Audit

Authored by epriestley <git@epriestley.com> on Jul 29 2014, 00:00.

Description

Write separate comments for every action in Audit

Summary:
Ref T4896. Depends on D10023. Prepares the code for the final migration.

The transaction table stores one row per distinct effect (e.g., add CCs) rather than one row per user action (e.g., "add CCs + comment"). We can double-read that table as long as the code doesn't expect transactions/comments to have multiple different effects, and doesn't try to write any such rows.

Everywhere that we were writing a big "X + Y" comment, write two separate "X" and "Y" comments instead. Like D10023, this disrupts the UI a little (you get more boxes), but that will be resolved once the rendering code swaps over. Otherwise, this retains the existing behavior.

Test Plan:

  • Used diffusion.createcomment to add comments, raise concern, and accept.
  • Previewed commenting, adding auditors/ccs, accepting, raising concern.
  • Actually performed commenting, adding auditors/ccs, accepting, raising concern.
  • Added a user with mentions.
  • Added an explicit CC and a mention user.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T4896

Differential Revision: https://secure.phabricator.com/D10052

Details

Committed
epriestley <git@epriestley.com>Jul 29 2014, 00:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbf397480114d: Build separate comments for each inline comment in Audit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH608e1d20b48a: Write separate comments for every action in Audit (authored by epriestley <git@epriestley.com>).Jul 29 2014, 00:00