Homec4science

Fix an issue with passing HTTP headers through in proxied cluster requests

Authored by epriestley <git@epriestley.com> on Apr 8 2016, 18:58.

Description

Fix an issue with passing HTTP headers through in proxied cluster requests

Summary:
I think this fixes the Mercurial + HTTP cluster issue. PHP adds HTTP_ but we were not stripping it, so we would convert an X-Whatever-Zebra header into an Http-X-Whatever-Zebra header.

I don't think this behavior has changed? So maybe it just never worked? Git is more popular than Mercurial and SSH is easier to configure than HTTP, so it's plausible. I'll keep a careful eye on this when it deploys.

Test Plan:

  • Set up local service-based Mercurial repository.
  • Tried to clone, got similar error to cluster.
  • Applied patch, clean clone.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15660

Details

Committed
epriestley <git@epriestley.com>Apr 8 2016, 20:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0900ffe9cb3e: Support sorting countdowns by end date
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH60e91d393421: Fix an issue with passing HTTP headers through in proxied cluster requests (authored by epriestley <git@epriestley.com>).Apr 8 2016, 20:03