Homec4science

Make inline reticle code more general and robust

Authored by epriestley <git@epriestley.com> on Mar 7 2015, 20:47.

Description

Make inline reticle code more general and robust

Summary:
Ref T2009. Currently, the code which draws the reticle is sort of implicitly hard-coded with some of the rules for the 2up view.

Instead, use general rules:

  • Start selection at the next <td />.
  • End selection at the rightmost adjacent <td />.

These rules work in all cases.

Test Plan:

  • Activated reticle in 1up and 2up views by clicking line numbers and hovering over comments. It now draws correctly.
  • Dragged over line ranges in 1up and 2up views, saw accurate reticle.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D12009

Details

Committed
epriestley <git@epriestley.com>Mar 7 2015, 20:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9ba430cca9e3: Fix Conpherence durable scrollbar with no USB devices
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH616976a45c83: Make inline reticle code more general and robust (authored by epriestley <git@epriestley.com>).Mar 7 2015, 20:47