Homec4science

Fix PhabricatorBot macro cacheing

Authored by Korvin Szanto <korvinszanto@gmail.com> on Aug 5 2013, 00:40.

Description

Fix PhabricatorBot macro cacheing

Summary:
Previously, if there were no macros, we would ping conduit for a list of macros until we got something. Now we cache false when there are no results.
T3045

Test Plan: Ensure the init doesn't call the macro.query conduit method more than once during the PhabricatorBot's lifetime.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Maniphest Tasks: T3045

Differential Revision: https://secure.phabricator.com/D6671

Details

Committed
epriestley <git@epriestley.com>Aug 5 2013, 00:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH40cf765ca299: Line highlighting for pastes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH61f0671e8730: Fix PhabricatorBot macro cacheing (authored by Korvin Szanto <korvinszanto@gmail.com>).Aug 5 2013, 00:40