Homec4science

Don't add author and reviewers to CCs in Herald

Authored by vrana <jakubv@fb.com> on Mar 30 2012, 15:25.

Description

Don't add author and reviewers to CCs in Herald

Summary:
Herald rules are adding CC also for Author and Reviewer.
See also D1397.
I was considering also just don't displaying the extra CC but this is probably better.

There are still cases where there could be reviewer in CC (e.g. by making reviewer from CC or by direct edit) but I think it's not a big problem.

Beeing both Reviewer and CC can be actually useful (e.g. if you resign than you still are in CC) but it's not that useful to justify this:

Author: vrana
Reviewers: epriestley
CCs: vrana, epriestley

Test Plan: Comment on revision where I am author.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2057

Details

Committed
vrana <jakubv@fb.com>Mar 30 2012, 19:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb38047006b1f: Show other open revisions affecting the same files in Differential
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH62053a39e373: Don't add author and reviewers to CCs in Herald (authored by vrana <jakubv@fb.com>).Mar 30 2012, 19:15