Various linter fixes.
627011476733
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Feb 26 2014, 21:44.

Description

Various linter fixes.

Summary:

Removed trailing newlines.
Added newline at EOF.
Removed leading newlines.
Trimmed trailing whitespace.
Spelling fix.
Added newline at EOF

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: hach-que, chad, Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8344

Details

Committed

epriestley <git@epriestley.com>

Feb 26 2014, 21:44

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH361e49dd6799: Symbol import: preemptively error on non-utf8 symbols

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH627011476733: Various linter fixes. (authored by Joshua Spence <josh@joshuaspence.com>).Feb 26 2014, 21:44

Changes (268)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path
	M			conf/production.conf.php
	M			resources/sql/patches/000.project.sql
	M			resources/sql/patches/0000.legacy.sql
	M			resources/sql/patches/002.oauth.sql
	M			resources/sql/patches/004.daemonrepos.sql
	M			resources/sql/patches/005.workers.sql
	M			resources/sql/patches/007.daemonlog.sql
	M			resources/sql/patches/009.repo_summary.sql
	M			resources/sql/patches/010.herald.sql
	M			resources/sql/patches/011.badcommit.sql
	M			resources/sql/patches/012.dropphidtype.sql
	M			resources/sql/patches/016.userrealnameindex.sql
	M			resources/sql/patches/018.owners.sql
	M			resources/sql/patches/020.pathcapital.sql
	M			resources/sql/patches/021.xhpastview.sql
	M			resources/sql/patches/024.mlistkeys.sql
	M			resources/sql/patches/025.commentopt.sql
	M			resources/sql/patches/026.diffpropkey.sql
	M			resources/sql/patches/028.systemagent.sql
	M			resources/sql/patches/034.savedheader.sql
	M			resources/sql/patches/036.mailkey.sql
	M			resources/sql/patches/043.pastebin.sql
	M			resources/sql/patches/044.countdown.sql
	M			resources/sql/patches/047.projectstatus.sql
	M			resources/sql/patches/049.projectowner.sql
	M			resources/sql/patches/052.pastelanguage.sql
	M			resources/sql/patches/053.feed.sql
	M			resources/sql/patches/055.add_author_to_files.sql
	M			resources/sql/patches/056.slowvote.sql
	M			resources/sql/patches/057.parsecache.sql
	M			resources/sql/patches/058.missingkeys.sql
	M			resources/sql/patches/060.phriction.sql
	M			resources/sql/patches/061.phrictioncontent.sql
	M			resources/sql/patches/062.phrictionmenu.sql
	M			resources/sql/patches/063.pasteforks.sql
	M			resources/sql/patches/064.subprojects.sql
	M			resources/sql/patches/065.sshkeys.sql
	M			resources/sql/patches/067.preferences.sql
	M			resources/sql/patches/068.maniphestauxiliarystorage.sql
	M			resources/sql/patches/076.indexedlanguages.sql
	M			resources/sql/patches/080.filekeys.sql
	M			resources/sql/patches/086.formeraffil.sql
	M			resources/sql/patches/087.phrictiondelete.sql
	M			resources/sql/patches/088.audit.sql
	M			resources/sql/patches/092.dropgithubnotification.sql
	M			resources/sql/patches/095.directory.sql
	M			resources/sql/patches/097.heraldruletypes.sql
	M			resources/sql/patches/099.drydock.sql
	M			resources/sql/patches/106.chatlog.sql
	M			resources/sql/patches/107.oauthserver.sql
	M			resources/sql/patches/108.oauthscope.sql
	M			resources/sql/patches/109.oauthclientphidkey.sql
	M			resources/sql/patches/110.commitaudit.sql
	M			resources/sql/patches/112.oauthaccesscoderedirecturi.sql
	M			resources/sql/patches/116.utf8-backup-first-expect-wait.sql
	M			resources/sql/patches/120.noop.sql
	M			resources/sql/patches/122.flag.sql
	M			resources/sql/patches/124.subpriority.sql
	M			resources/sql/patches/128.phabricatorcom.sql
	M			resources/sql/patches/132.phame.sql
	M			resources/sql/patches/20121209.pholioxactions.sql
	M			resources/sql/patches/20130111.conpherence.sql
	M			resources/sql/patches/20130127.altheraldtranscript.sql
	M			resources/sql/patches/20130131.conpherencepics.sql
	M			resources/sql/patches/20130214.chatlogchannel.sql
	M			resources/sql/patches/20130215.phabricatorfileaddttl.sql
	M			resources/sql/patches/20130317.phrictionedge.sql
	M			resources/sql/patches/20130320.phlux.sql
	M			resources/sql/patches/20130322.phortune.sql
	M			resources/sql/patches/20130417.externalaccount.sql
	M			resources/sql/patches/20130519.diviner.sql
	M			resources/sql/patches/20130606.userxactions.sql
	M			resources/sql/patches/20130620.diffxactions.sql
	M			resources/sql/patches/20130622.doorkeeper.sql
	M			resources/sql/patches/20130628.legalpadv0.sql
	M			resources/sql/patches/20130723.taskstarttime.sql
	M			resources/sql/patches/20130726.ponderxactions.sql
	M			resources/sql/patches/20130820.filexactions.sql
	M			resources/sql/patches/20130926.dinkeys.sql
	M			resources/sql/patches/20131030.repostatusmessage.sql
	M			resources/sql/patches/20131224.harbormanual.sql
	M			resources/sql/patches/20131227.heraldobject.sql
	M			resources/sql/patches/20131302.maniphestvalue.sql
	M			resources/sql/patches/emailtableremove.sql
	M			resources/sql/patches/phameblog.sql
	M			resources/sql/patches/phamedomain.sql
	M			resources/sql/patches/phamepolicy.sql
	M			resources/sql/patches/phiddrop.sql
	M			resources/sql/patches/ponder-comments.sql
	M			resources/sql/patches/ponder.sql
	M			scripts/differential/destroy_revision.php
	M			scripts/mail/mail_handler.php
	M			scripts/mail/manage_mail.php
	M			scripts/repository/test_connection.php
	M			scripts/search/reindex_maniphest.php
	M			src/aphront/console/DarkConsoleCore.php
	M			src/aphront/console/plugin/DarkConsoleServicesPlugin.php
	M			src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
	M			src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php
	M			src/applications/audit/application/PhabricatorApplicationAudit.php
	M			src/applications/audit/events/AuditActionMenuEventListener.php
	M			src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
	M			src/applications/base/controller/__tests__/PhabricatorApplicationTest.php
	M			src/applications/chatlog/applications/PhabricatorApplicationChatLog.php
	M			src/applications/chatlog/storage/PhabricatorChatLogChannel.php
	M			src/applications/config/check/PhabricatorSetupCheckImagemagick.php
	M			src/applications/config/storage/PhabricatorConfigTransaction.php
	M			src/applications/conpherence/events/ConpherenceActionMenuEventListener.php
	M			src/applications/conpherence/events/ConpherenceHovercardEventListener.php
	M			src/applications/differential/application/PhabricatorApplicationDifferential.php
	M			src/applications/differential/controller/DifferentialRevisionLandController.php
	M			src/applications/differential/editor/DifferentialRevisionEditor.php
	M			src/applications/differential/event/DifferentialActionMenuEventListener.php
	M			src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php
	M			src/applications/differential/mail/DifferentialExceptionMail.php
	M			src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
	M			src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php
	M			src/applications/differential/storage/DifferentialCustomFieldStorage.php
	M			src/applications/differential/storage/DifferentialCustomFieldStringIndex.php
	M			src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php
	M			src/applications/diffusion/controller/DiffusionServeController.php
	M			src/applications/diffusion/events/DiffusionHovercardEventListener.php
	M			src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php
	M			src/applications/diviner/application/PhabricatorApplicationDiviner.php
	M			src/applications/diviner/atomizer/DivinerPHPAtomizer.php
	M			src/applications/drydock/worker/DrydockAllocatorWorker.php
	M			src/applications/feed/application/PhabricatorApplicationFeed.php
	M			src/applications/flag/application/PhabricatorApplicationFlags.php
	M			src/applications/flag/events/PhabricatorFlagsUIEventListener.php
	M			src/applications/herald/adapter/HeraldAdapter.php
	M			src/applications/herald/engine/HeraldEffect.php
	M			src/applications/herald/storage/HeraldRuleTransactionComment.php
	M			src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php
	M			src/applications/macro/storage/PhabricatorFileImageMacro.php
	M			src/applications/macro/storage/PhabricatorMacroTransaction.php
	M			src/applications/macro/storage/PhabricatorMacroTransactionComment.php
	M			src/applications/maniphest/application/PhabricatorApplicationManiphest.php
	M			src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php
	M			src/applications/maniphest/storage/ManiphestCustomFieldStorage.php
	M			src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php
	M			src/applications/maniphest/storage/ManiphestTransaction.php
	M			src/applications/meta/application/PhabricatorApplicationApplications.php
	M			src/applications/meta/controller/PhabricatorApplicationUninstallController.php
	M			src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php
	M			src/applications/nuance/application/PhabricatorApplicationNuance.php
	M			src/applications/nuance/query/NuanceItemQuery.php
	M			src/applications/nuance/query/NuanceQuery.php
	M			src/applications/nuance/query/NuanceQueueQuery.php
	M			src/applications/nuance/query/NuanceRequestorQuery.php
	M			src/applications/nuance/source/NuanceSourceDefinition.php
	M			src/applications/owners/mail/OwnersPackageReplyHandler.php
	M			src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php
	M			src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php
	M			src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php
	M			src/applications/people/storage/PhabricatorUserTransaction.php
	M			src/applications/pholio/event/PholioActionMenuEventListener.php
	M			src/applications/phragment/application/PhabricatorApplicationPhragment.php
	M			src/applications/phrequent/application/PhabricatorApplicationPhrequent.php
	M			src/applications/phrequent/query/PhrequentSearchEngine.php
	M			src/applications/phriction/application/PhabricatorApplicationPhriction.php
	M			src/applications/policy/application/PhabricatorApplicationPolicy.php
	M			src/applications/policy/capability/PhabricatorPolicyCapability.php
	M			src/applications/policy/query/PhabricatorPolicyQuery.php
	M			src/applications/ponder/remarkup/PonderRemarkupRule.php
	M			src/applications/ponder/storage/PonderAnswerTransaction.php
	M			src/applications/ponder/storage/PonderAnswerTransactionComment.php
	M			src/applications/ponder/storage/PonderComment.php
	M			src/applications/ponder/storage/PonderQuestionTransactionComment.php
	M			src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php
	M			src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php
	M			src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php
	M			src/applications/releeph/storage/ReleephBranchTransaction.php
	M			src/applications/releeph/storage/ReleephProjectTransaction.php
	M			src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
	M			src/applications/repository/storage/PhabricatorRepositoryTransaction.php
	M			src/applications/search/controller/PhabricatorSearchAttachController.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php
	M			src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php
	M			src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php
	M			src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php
	M			src/applications/transactions/application/PhabricatorApplicationTransactions.php
	M			src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
	M			src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php
	M			src/applications/transactions/view/PhabricatorApplicationTransactionView.php
	M			src/applications/typeahead/storage/PhabricatorTypeaheadResult.php
	M			src/docs/user/configuration/troubleshooting_https.diviner
	M			src/docs/user/contributing/php_coding_standards.diviner
	M			src/docs/user/developer/adding_new_css_and_js.diviner
	M			src/docs/user/developer/unit_tests.diviner
	M			src/docs/user/developer/using_oauthserver.diviner
	M			src/docs/user/flavortext/javascript_object_array.diviner
	M			src/docs/user/flavortext/javascript_pitfalls.diviner
	M			src/docs/user/flavortext/things_you_should_do_now.diviner
	M			src/docs/user/userguide/arcanist_lint.diviner
	M			src/docs/user/userguide/differential_test_plans.diviner
	M			src/docs/user/userguide/herald.diviner
	M			src/docs/user/userguide/mail_rules.diviner
	M			src/docs/user/userguide/maniphest_custom.diviner
	M			src/docs/user/userguide/phame.diviner
	M			src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php
	M			src/infrastructure/celerity/CeleritySpriteGenerator.php
	M			src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php
	M			src/infrastructure/events/PhabricatorEvent.php
	M			src/infrastructure/events/PhabricatorEventListener.php
	M			src/infrastructure/events/PhabricatorExampleEventListener.php
	M			src/view/control/AphrontTableView.php
	M			src/view/layout/PhabricatorFileLinkListView.php
	M			src/view/viewutils.php
	M			support/aphlict/client/aphlict_test_client.php
	M			support/empty/README
	M			webroot/index.php
	M			webroot/rsrc/css/aphront/lightbox-attachment.css
	M			webroot/rsrc/css/aphront/phabricator-nav-view.css
	M			webroot/rsrc/css/application/conpherence/notification.css
	M			webroot/rsrc/css/application/differential/core.css
	M			webroot/rsrc/css/application/maniphest/batch-editor.css
	M			webroot/rsrc/css/application/people/people-profile.css
	M			webroot/rsrc/css/layout/phabricator-action-header-view.css
	M			webroot/rsrc/css/phui/phui-icon.css
	M			webroot/rsrc/externals/javelin/LICENSE
	M			webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js
	M			webroot/rsrc/externals/javelin/core/__tests__/install.js
	M			webroot/rsrc/externals/javelin/docs/Base.js
	M			webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner
	M			webroot/rsrc/externals/javelin/docs/onload.js
	M			webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js
	M			webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
	M			webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js
	M			webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js
	M			webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js
	M			webroot/rsrc/externals/javelin/ext/view/HTMLView.js
	M			webroot/rsrc/externals/javelin/ext/view/View.js
	M			webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js
	M			webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js
	M			webroot/rsrc/externals/javelin/lib/DOM.js
	M			webroot/rsrc/externals/javelin/lib/__tests__/URI.js
	M			webroot/rsrc/externals/javelin/lib/__tests__/behavior.js
	M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js
	M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js
	M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js
	M			webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
	M			webroot/rsrc/image/icon/fatcow/README
	M			webroot/rsrc/js/application/config/behavior-reorder-fields.js
	M			webroot/rsrc/js/application/countdown/timer.js
	M			webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js
	M			webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js
	M			webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
	M			webroot/rsrc/js/application/diffusion/behavior-commit-branches.js
	M			webroot/rsrc/js/application/diffusion/behavior-commit-graph.js
	M			webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js
	M			webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js
	M			webroot/rsrc/js/application/files/behavior-icon-composer.js
	M			webroot/rsrc/js/application/files/behavior-launch-icon-composer.js
	M			webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js
	M			webroot/rsrc/js/application/maniphest/behavior-line-chart.js
	M			webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js
	M			webroot/rsrc/js/application/search/behavior-reorder-queries.js
	M			webroot/rsrc/js/core/FileUpload.js
	M			webroot/rsrc/js/core/MultirowRowManager.js
	M			webroot/rsrc/js/core/Notification.js
	M			webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js
	M			webroot/rsrc/js/core/behavior-global-drag-and-drop.js
	M			webroot/rsrc/swf/test.html