Homec4science

Remove a check for closing revisions

Authored by Nick Harper <nharper@fb.com> on Aug 11 2012, 01:15.

Description

Remove a check for closing revisions

Summary:
I ran into a case where a commit isn't "new" but hasn't been closed. I
think the check on the status of the differential revision should be
enough and this check isn't needed.

Test Plan:
used the reparse.php script to close a revision that previously wouldn't
close.

Reviewers: epriestley, vrana

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3232

Details

Committed
Nick Harper <nharper@fb.com>Aug 11 2012, 01:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4eebd545ce90: Removing memory limit sanity check
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH62b3e4aea355: Remove a check for closing revisions (authored by Nick Harper <nharper@fb.com>).Aug 11 2012, 01:15