Homec4science

Fix error with inline comments on images

Authored by epriestley <git@epriestley.com> on Dec 21 2012, 23:16.

Description

Fix error with inline comments on images

Summary: This data structure is a dict<int, list<Comment>> now, where the int is the line number.

Test Plan:

  • Created a diff changing an image.
  • Added inline comments on the left and right sides of the diff.
  • Saw some exceptions and general sadness.
  • Applied patch.
  • Reloaded page.
  • Everything worked great.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D4264

Details

Committed
epriestley <git@epriestley.com>Dec 21 2012, 23:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPH394340fd8ffa: Rename setViewer() to setUser() in feed.query
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH62bc3373e5a6: Fix error with inline comments on images (authored by epriestley <git@epriestley.com>).Dec 21 2012, 23:16