Homec4science

Hovercard front-end code & stuff

Authored by Anh Nhan Nguyen <anhnhan@outlook.com> on Apr 5 2013, 17:31.

Description

Hovercard front-end code & stuff

Summary:
Refs T1048; Depends on D5557, D5558

They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558)

Worth a lot of improvement. But it's great for now after a little bit of styling.

Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented.

Added some seemingly useful graceful situations. Too much to the left, too much to the top.

Test Plan:
Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear.

Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches.

For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard.

Reviewers: epriestley, chad, btrahan

CC: aran, Korvin

Maniphest Tasks: T1048

Differential Revision: https://secure.phabricator.com/D5563

Conflicts:

src/__celerity_resource_map__.php

Details

Committed
epriestley <git@epriestley.com>Apr 5 2013, 17:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa8418990d01c: Fix urls in Action Headers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH635bd1ef07c2: Hovercard front-end code & stuff (authored by Anh Nhan Nguyen <anhnhan@outlook.com>).Apr 5 2013, 17:44