Homec4science

Don't show comment draft state to non-object-owners

Authored by epriestley <git@epriestley.com> on Apr 2 2015, 16:27.

Description

Don't show comment draft state to non-object-owners

Summary: Fixes T7720. We currently leak the "draft" state of checkboxes; never treat checkboxes as drafts if you can't mark them.

Test Plan: Checked a box, reloaded page in other browser. Previously, the draft state partially propagated. Now, it no longer does.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7720

Differential Revision: https://secure.phabricator.com/D12262

Details

Committed
epriestley <git@epriestley.com>Apr 2 2015, 16:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1ae1cdd7bac4: Herald queries correctly label Object Rules
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH638cdb8d5773: Don't show comment draft state to non-object-owners (authored by epriestley <git@epriestley.com>).Apr 2 2015, 16:27