Homec4science

Change All Search Boxes into Jump Navs

Authored by David Fisher <ddf1991@gmail.com> on Mar 6 2012, 04:51.

Description

Change All Search Boxes into Jump Navs

Summary:

  • all search boxes are now jump navs (old functionality retained if none of the jump nav patterns match)
  • added global keyboard shortcut '/' to focus the search box in the upper right

Test Plan:

  • pressed '/' and noticed the search box gains keyboard focus
  • triggered jump nav functionality from search box and saw it worked
  • did a search which did not match a jump nav pattern and saw it worked (and searched in the selected context)
NOTE: The search box on the /search/ page is also changed to have jump nav functionality. Old functionality is not impared. Still, this may not be desirable.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1794

Details

Committed
epriestley <git@epriestley.com>Mar 6 2012, 04:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH831133e8802c: Minor, fix some obvious derp from the attachment patch.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH639ed0faa699: Change All Search Boxes into Jump Navs (authored by David Fisher <ddf1991@gmail.com>).Mar 6 2012, 04:52