Homec4science

Phame - fix some issues with feed reported on github (290, 291)

Authored by Bob Trahan <bob.trahan@gmail.com> on Apr 12 2013, 01:10.

Description

Phame - fix some issues with feed reported on github (290, 291)

Summary: we need a link with type=self to pass xml validation. Note we will always fail validation until we remove any sigil-related stuff from the resultant HTML since we just made that up for our purposes. Also serves up the feed link on the blog view controller, complete with tooltip about how the custom domain stuff isn't supported.

Test Plan: viewed a blog page and liked the feed uri property. viewed a feed and verified the new link self stuff. post push I'll try the validator again.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, vrana

Differential Revision: https://secure.phabricator.com/D5667

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Apr 12 2013, 01:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2b8adb3a83e4: Don't hang on `/status/` for newer Node
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH649f5cc178bf: Phame - fix some issues with feed reported on github (290, 291) (authored by Bob Trahan <bob.trahan@gmail.com>).Apr 12 2013, 01:10