Homec4science

Remove Controller->getHandle() and Controller->loadHandles()

Authored by epriestley <git@epriestley.com> on Mar 30 2015, 16:55.

Description

Remove Controller->getHandle() and Controller->loadHandles()

Summary: Ref T7689. Modernize all callsites of these methods.

Test Plan:

  • Poked at dashboards.
    • Pretty sure this code is technically unreachable right now.
  • Viewed commit; viewed "Audit Status".
  • Viewed a fund; viewed "Payable to"; viewed "Owner".
  • Viewed herald rules; viewed "Author"; viewed "Applies To".
  • Viewed a Legalpad document; viewed "Contributors".
  • Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
  • Viewed a macro; viewed "Audio".
  • Viewed a Phriction page; viewed "Last Author".
  • Viewed a Ponder question; viewed "Author".
  • Viewed a Ponder answer; viewed header.
    • Behavior changed very slightly here; whatevs.
  • Viewed a Countdown; viewed "Author".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12210

Details

Committed
epriestley <git@epriestley.com>Mar 31 2015, 14:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0f52fc771dc0: Remove implode_selected_handle_links()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH64dddc76c5cd: Remove Controller->getHandle() and Controller->loadHandles() (authored by epriestley <git@epriestley.com>).Mar 31 2015, 14:48