Homec4science

Convert all remaining old tabs to new PHUITabGroupViews

Authored by epriestley <git@epriestley.com> on Jul 1 2016, 01:28.

Description

Convert all remaining old tabs to new PHUITabGroupViews

Summary: Ref T10628. This moves everything else over. I'll clean up the cruft in the next diff.

Test Plan:

  • Viewed Conduit API page, toggled tabs.
  • Viewed Harbormaster build, toggled tabs.
  • Viewed a Drydock lease, swapped tabs.
  • Viewed a Drydock resource, swapped tabs.
  • Viewed mail, swapped tabs.
  • Grepped for addPropertyList(...), looked for any remaining calls with a second argument.
  • Also checked rSAAS for any calls, but we don't have anything there that uses tabs.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16207

Details

Committed
epriestley <git@epriestley.com>Jul 1 2016, 03:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5a4ecc7a9c5b: Convert "Diff Details" tabs to PHUITabGroup
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH65980ac68347: Convert all remaining old tabs to new PHUITabGroupViews (authored by epriestley <git@epriestley.com>).Jul 1 2016, 03:50