Homec4science

Pholio - make inline comment box appear correctly

Authored by Bob Trahan <bob.trahan@gmail.com> on Jul 11 2013, 00:17.

Description

Pholio - make inline comment box appear correctly

Summary: Fixes T3509. Generally tried to make the code more consistently use get_image_scale, as well as make get_image_scale aware that sometimes images need to be scaled because they're too tall (as well as too wide).

Test Plan: used the file from T3509. noted comment box appearing correctly as clicked, or clicked and dragged. submitted some comments and noted the reticles moved / scaled correctly as I resized the browser window

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3509

Differential Revision: https://secure.phabricator.com/D6418

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jul 11 2013, 00:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa92ef7d9a2d3: Modernize MetaMTA message detail
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH65ab9d178033: Pholio - make inline comment box appear correctly (authored by Bob Trahan <bob.trahan@gmail.com>).Jul 11 2013, 00:17