Homec4science

Expand comments on page load only when the anchor points into them

Authored by epriestley <git@epriestley.com> on May 6 2013, 20:44.

Description

Expand comments on page load only when the anchor points into them

Summary:
Ref T3099. Currently, we expand comments in Differential when any anchor is present. This creates a scrolling issue described in T3099. Instead, expand them only when the anchor contains comment.

We can go further here, but this should fix the immediate issue.

Test Plan: Viewed /D22, /D22#toc, and /D22#comment-3. The first two did not expand comments; the last one did.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3099

Differential Revision: https://secure.phabricator.com/D5836

Details

Committed
epriestley <git@epriestley.com>May 6 2013, 20:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf76ecd9e764c: Adding Handle Suport
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH67459092d7c9: Expand comments on page load only when the anchor points into them (authored by epriestley <git@epriestley.com>).May 6 2013, 20:44