Homec4science

Restore phutil_split_lines() to Differential

Authored by epriestley <git@epriestley.com> on Oct 20 2012, 16:11.

Description

Restore phutil_split_lines() to Differential

Summary:
Same as D3759 with a fix:

Previously, we would insert null to indicate a line that doesn't exist on one side of a diff, and then implode on "\n", so we'd get "\n" as a result.

In D3759, we'd insert null but implode on empty string, and get nothing as a result.

When a placeholder null is present, explicitly insert a newline.

Test Plan: D3759 plus examined a diff with removed lines on the left side prior to new lines on the right side.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3765

Details

Committed
epriestley <git@epriestley.com>Oct 20 2012, 16:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH468aeaef0db7: Revert "Use phutil_split_lines() in Differential"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH67498f33340a: Restore phutil_split_lines() to Differential (authored by epriestley <git@epriestley.com>).Oct 20 2012, 16:24