Homec4science

Remove (most) support for 'differential.attach-task-class'

Authored by epriestley <git@epriestley.com> on Aug 18 2011, 21:29.

Description

Remove (most) support for 'differential.attach-task-class'

Summary:
After D814 and D829, you should be able to implement this logic in the
didWriteRevision() method of the field.

Note that the attacher is still referenced in
ConduitAPI_differential_updatetaskrevisionassoc_Method. This method should
probably be moved to facebook/ since it's pretty Facebook-specific.

No rush on any of this, it's not hurting anything.

Test Plan:

  • Hit differential.getcommitmessage
  • Ran 'arc diff'

Reviewers: jungejason, tuomaspelkonen, aran

Reviewed By: jungejason

CC: aran, jungejason

Differential Revision: 830

Details

Committed
epriestley <git@epriestley.com>Aug 19 2011, 23:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHed33e59c5aa1: Fix login issue with stale HTTP vs HTTPS cookies
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH67de714a2f85: Remove (most) support for 'differential.attach-task-class' (authored by epriestley <git@epriestley.com>).Aug 19 2011, 23:10