Homec4science

Make marking comments as "Done" work cleanly on EditEngine

Authored by epriestley <git@epriestley.com> on Dec 31 2016, 18:57.

Description

Make marking comments as "Done" work cleanly on EditEngine

Summary: Ref T11114. Fixes T10323.

Test Plan:

  • Marked comments as done only: no warning about not leaving a comment.
  • Did nothing: warning about posting an empty comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114, T10323

Differential Revision: https://secure.phabricator.com/D17120

Details

Committed
epriestley <git@epriestley.com>Dec 31 2016, 19:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa4ba7daf9009: Add transitional support for mail tags to Differential on EditEngine
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine (authored by epriestley <git@epriestley.com>).Dec 31 2016, 19:12