Homec4science

Don't spend ridiculous amounts of time rebuilding orderable columns

Authored by epriestley <git@epriestley.com> on Jun 17 2015, 04:32.

Description

Don't spend ridiculous amounts of time rebuilding orderable columns

Summary:
Ref T8575. Because orderable columns need to build custom fields, they are relatively expensive to build. Use the request cache.

(The request cache is technically more correct than static, because configuration may change between requests and we may eventually reuse interpreters.)

Test Plan: Saw home page time drop 39% (from 462ms to 283ms).

Reviewers: btrahan, avivey

Reviewed By: avivey

Subscribers: avivey, epriestley

Maniphest Tasks: T8575

Differential Revision: https://secure.phabricator.com/D13322

Details

Committed
epriestley <git@epriestley.com>Jun 17 2015, 04:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8484adcffdf6: Cache application visibility in the request cache
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6933ee5fb86d: Don't spend ridiculous amounts of time rebuilding orderable columns (authored by epriestley <git@epriestley.com>).Jun 17 2015, 04:32