Homec4science

Remove `phpast.*` Conduit methods

Authored by epriestley <git@epriestley.com> on Mar 12 2014, 19:30.

Description

Remove phpast.* Conduit methods

Summary:
Ref T4592. These were added with the intent of not requiring builds on Windows, but then we got builds on Windows working and they seem to be straightforward. See T4592 for most recent discussion.

Remove these methods because they aren't really practical for anything and increase attack surface area by giving adversaries access to xhpast, and generally bloat up the Conduit API. To my knowledge, nothing has ever called them.

(If an install somehow relies on these, they can drop them into src/extensions/ to expose them again.)

Test Plan: Viewed conduit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4592

Differential Revision: https://secure.phabricator.com/D8500

Details

Committed
epriestley <git@epriestley.com>Mar 12 2014, 19:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7176240717f2: Whitelist controllers which can receive a 'code' parameter
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH69399dfc2ad2: Remove `phpast.*` Conduit methods (authored by epriestley <git@epriestley.com>).Mar 12 2014, 19:30