Homec4science

Render remarkup in feed in a mostly reasonable way

Authored by epriestley <git@epriestley.com> on Aug 26 2014, 23:36.

Description

Render remarkup in feed in a mostly reasonable way

Summary:
Fixes T4057. This sort of sidesteps the trickiest (but very rare) case of things like embedded slowvotes. We might be able to refine that later.

In the common bad case (macros, large images) it gets reasonable results by using overflow: hidden with max-height.

We use PhabriatorMarkupEngine::summarize() to try to just render the first paragraph.

Test Plan: {F195093}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4057

Differential Revision: https://secure.phabricator.com/D10355

Details

Committed
epriestley <git@epriestley.com>Aug 26 2014, 23:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd13d6963dde0: phd - make stop / restart savvy to daemons without pid files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH69b0ac724a7c: Render remarkup in feed in a mostly reasonable way (authored by epriestley <git@epriestley.com>).Aug 26 2014, 23:36