Homec4science

Transactions - deploy buildTransactionTimeline against a few more applications

Authored by Bob Trahan <btrahan@phacility.com> on Dec 2 2014, 23:33.

Description

Transactions - deploy buildTransactionTimeline against a few more applications

Summary:
Ref T4712. Thus far, it seems that most "non-standard" things can be done pretty easily in the controller. Aside from deploying, this diff had to fix a few bugs / missing implementations of stuff.

(Notably, PhabricatorAuthProviderConfig, HeraldRule, PhabricatorSlowvotePoll, and AlmanacNetwork needed to implement PhabricatorApplicationTransactionInterface, PhabricatorAuthAuthProviderPHIDType had to be added, and a rendering bug in transactions of type PhabricatorOAuth2AuthProvider had to be fixed.)

Test Plan: Almanac - looked at binding, device, network, and service view controllers and verified timeline displayed properly. Herald - looked at a rule and verified timeline. Slowvote - looked at a vote and verified timeline. Auth - looked at an auth provider (Facebook) and verified proper display of transactions within timeline.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4712

Differential Revision: https://secure.phabricator.com/D10921

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 2 2014, 23:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf88b8a452062: Mobile ready Audit/Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH69cc5df6456b: Transactions - deploy buildTransactionTimeline against a few more applications (authored by Bob Trahan <btrahan@phacility.com>).Dec 2 2014, 23:33