Homec4science

Move Macro image height/width to CSS

Authored by Chad Little <chad@chadsdomain.com> on Mar 12 2015, 01:35.

Description

Move Macro image height/width to CSS

Summary: This makes macros and memes grow to 100% of their container at most, instead of showing a scrollbar. This is useful for overly large macros, smaller spaces like Feed and Conpherences, and Inline Comments. Fixes T7528

Test Plan: Tested a very large macro, a very large meme, and a very very tiny macro. It looks like memes get cached though, unsure if we should clean them up or just leave them

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7528

Differential Revision: https://secure.phabricator.com/D12045

Details

Committed
Chad Little <chad@chadsdomain.com>Mar 12 2015, 01:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7d7deaf69802: Conpherence - fix "pop in" effect
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@chadsdomain.com> committed rPH6a036f32b249: Move Macro image height/width to CSS (authored by Chad Little <chad@chadsdomain.com>).Mar 12 2015, 01:35