Homec4science

When `cluster.databases` is configured, read the master connection from it

Authored by epriestley <git@epriestley.com> on Apr 10 2016, 04:46.

Description

When cluster.databases is configured, read the master connection from it

Summary:
Ref T4571. Ref T10759. Ref T10758. This isn't complete, but gets most of the job done:

  • When cluster.databases is set up, most things ignore mysql.host now.
  • You can bin/storage upgrade and stuff works.
  • You can browse around in the web UI and stuff works.

There's still a lot of weird tricky stuff to navigate, and this has real no advantages over configuring a single server yet (no automatic failover, etc).

Test Plan:

  • Configured cluster.databases to point at my t1.micro hosts in EC2 (master + replica).
  • Ran bin/storage upgrade, got a new install setup on them properly.
  • Survived setup warnings, browsed around.
  • Switched back to local config, ran bin/storage upgrade, browsed around, went through setup checks.
  • Intentionally broke config (bad hosts, no masters) and things seemed to react reasonably well.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4571, T10758, T10759

Differential Revision: https://secure.phabricator.com/D15668

Details

Committed
epriestley <git@epriestley.com>Apr 10 2016, 21:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0439645d5bb0: Add a "Database Cluster Status" console in Config
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6a4a9bb2d284: When `cluster.databases` is configured, read the master connection from it (authored by epriestley <git@epriestley.com>).Apr 10 2016, 21:18