Simplify context parsing and add test coverage
6a6910835874
Actions

Authored by epriestley <git@epriestley.com> on Jan 11 2013, 01:06.

Description

Simplify context parsing and add test coverage

Summary:

Remove 'missingNew', etc. It's impossible for a diff to popluate these, as far as I can tell (I can't generate such a diff, or find any which generate it).
Add unit tests.

Test Plan: Unit tests, viewed a diff with some missing context.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Committed

epriestley <git@epriestley.com>

Jan 11 2013, 01:06

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHebf2435c49fe: Make feed its own application

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH6a6910835874: Simplify context parsing and add test coverage (authored by epriestley <git@epriestley.com>).Jan 11 2013, 01:06

		Path
M		src/applications/differential/parser/DifferentialChangesetParser.php
M		src/applications/differential/parser/DifferentialHunkParser.php
M		src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
A	(dir)	src/applications/differential/parser/__tests__/data/
A		src/applications/differential/parser/__tests__/data/missing_context.diff
A		src/applications/differential/parser/__tests__/data/missing_context_2.diff
A		src/applications/differential/parser/__tests__/data/missing_context_3.diff
M		src/applications/differential/render/DifferentialChangesetRenderer.php
M		src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php