Homec4science

Don't show notifications about your own actions

Authored by epriestley <git@epriestley.com> on Jan 8 2015, 18:43.

Description

Don't show notifications about your own actions

Summary:
Ref T6559. See discussion in D11143. At least locally, WebSockets are too fast and create immediate local notifications on page submit.

To mitigate this, don't notify about your own actions.

This isn't perfect (we get the other-copies-of-the-window-open-in-other-tabs case wrong) but I think the case we get wrong is rare / not very important.

Test Plan: Submitted stuff, saw other users get notifications but not me.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6559

Differential Revision: https://secure.phabricator.com/D11275

Details

Committed
epriestley <git@epriestley.com>Jan 8 2015, 18:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc0e15f2c6587: Fix bad ancestor classname
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6a7469e1aaee: Don't show notifications about your own actions (authored by epriestley <git@epriestley.com>).Jan 8 2015, 18:43