Homec4science

Allow Herald rules to check for revisions with no reviewers

Authored by epriestley <git@epriestley.com> on Dec 11 2013, 23:46.

Description

Allow Herald rules to check for revisions with no reviewers

Summary: Fixes T4225. Adds the NON_EXISTS condition to Herald for "Reviewers", and adds a few more conditions which have reasonable meanings.

Test Plan: Used test console to check a revision with reviewers, and another without reviewers. Both produced the expected results.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4225

Differential Revision: https://secure.phabricator.com/D7757

Details

Committed
epriestley <git@epriestley.com>Dec 11 2013, 23:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc3d9c2838228: Specify an ssh port for Diffusion when running against the grain
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6b1ec35cf377: Allow Herald rules to check for revisions with no reviewers (authored by epriestley <git@epriestley.com>).Dec 11 2013, 23:46