Homec4science

Modernize Diviner

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 16 2015, 23:09.

Description

Modernize Diviner

Summary:
Ref T4558. This diff modernizes the #diviner application. Basically:

  • Add an edit controller, accessible at /book/$BOOK/edit/.
  • Add edit/view policies.
  • Added an action menu to the DivinerBookController to expose the edit interface.
  • Allows projects to be associated with books.
  • Implement edges and transactions.
  • Implemented PhabricatorApplicationTransactionInterface in DivinerLiveBook.

Test Plan:

  • Generated a Diviner book with ./bin/diviner generate.
  • Added projects to a book and ensured that they persisted.
  • Changed the view policy on a book and made sure it was effective.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4558

Differential Revision: https://secure.phabricator.com/D13091

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 16 2015, 23:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc5c5523c1ff8: Add missing $mailer property to PhabricatorMailImplementationPHPMailerAdapter
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH6b7d7401ca6d: Modernize Diviner (authored by Joshua Spence <josh@joshuaspence.com>).Jun 16 2015, 23:17