Homec4science

Fixed 'Create Diff'

Authored by tuomaspelkonen <tuomaspelkonen@fb.com> on Jun 16 2011, 21:01.

Description

Fixed 'Create Diff'

Summary:
'Create Diff' with whitespace mode 'ignore-all' is borken, because the
line numbers get mixed up when creating a second diff for the
whitespace changes.

This should be fixed correctly at some point, but currently the
whitespace 'ignore-all' says 'Huge mess' in the comments and I didn't
want to make the mess any bigger.

Test Plan:
Tested that 'Create Diff' showed the diff correctly and a previously
created diff looked correct once the cache was disabled.

Reviewed By: epriestley
Reviewers: epriestley, jungejason
CC: aran, epriestley
Differential Revision: 473

Details

Committed
tuomaspelkonen <tuomaspelkonen@fb.com>Jun 19 2011, 00:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH988b038e2e15: Merge pull request #21 from CodeBlock/master
Branches
Unknown
Tags
Unknown
Reverted By
rPHe5bb756b5191: Revert "Fixed 'Create Diff'"

Event Timeline

tuomaspelkonen <tuomaspelkonen@fb.com> committed rPH6b7db2752456: Fixed 'Create Diff' (authored by tuomaspelkonen <tuomaspelkonen@fb.com>).Jun 19 2011, 00:33