Homec4science

Fix HTTP 400 from notification server for JSON subscription objects

Authored by epriestley <git@epriestley.com> on Jul 17 2014, 23:48.

Description

Fix HTTP 400 from notification server for JSON subscription objects

Summary: Fixes T5651. Sometime we'll send an object to the notification server for subscribers, which it will choke on. Use array_values() to make sure we're sending an array.

Test Plan: With (object) instead, got a consistent error ("no .filter method on object"). With array_values(), no error.

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5651

Differential Revision: https://secure.phabricator.com/D9963

Details

Committed
epriestley <git@epriestley.com>Jul 17 2014, 23:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPHab3c17a2cd97: Emit more usable results from phrequent.tracking
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6bf4ec97d563: Fix HTTP 400 from notification server for JSON subscription objects (authored by epriestley <git@epriestley.com>).Jul 17 2014, 23:48