Homec4science

Conpherence - change message rendering logic to eradicate possibility of…

Authored by Bob Trahan <btrahan@phacility.com> on May 13 2015, 20:06.

Description

Conpherence - change message rendering logic to eradicate possibility of duplicates

Summary:
Fixes T6713. Before this diff, we would update the DOM when various requests came back, but the logic to erase race conditions proved too tricky for me to get right. Instead, change the algorithm up and keep a set of transaction ids around per thread. When its time to update the transactions, sort the list of ids and just render the whole darn set again.

To make this work, this ends up adding transacton ids to fake transactons like "show older" and date markers. This is able to work by using a float sort and giving these transactions ids that are .5 from being an integer and in the right place numerically.

Test Plan: for durable column, clicked show older and it worked. sent a message and it worked. for main view, clicked show older and it worked. sent a message and it worked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6713

Differential Revision: https://secure.phabricator.com/D12819

Details

Committed
Bob Trahan <btrahan@phacility.com>May 13 2015, 20:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH20b7308dfb9f: Month view should adjust to display badges with event count instead of event…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH6c049d06ce4d: Conpherence - change message rendering logic to eradicate possibility of… (authored by Bob Trahan <btrahan@phacility.com>).May 13 2015, 20:06