Homec4science

Fix line count in diffs with more hunks per changeset

Authored by vrana <jakubv@fb.com> on Jun 27 2012, 23:45.

Description

Fix line count in diffs with more hunks per changeset

Summary: This error usually doesn't occur because we have only one hunk per changeset most of the time.

Test Plan:

$hunk = new ArcanistDiffHunk();
$hunk->setAddLines(1);
$hunk->setDelLines(1);

$change = new ArcanistDiffChange();
$change->addHunk($hunk);
$change->addHunk($hunk);

$diff = DifferentialDiff::newFromRawChanges(array($change));
var_dump($diff->getLineCount());

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2878

Details

Committed
vrana <jakubv@fb.com>Jun 28 2012, 03:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH692e54ee36fb: Implement a MySQL-backed global lock
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH6c1c3c3a7a7a: Fix line count in diffs with more hunks per changeset (authored by vrana <jakubv@fb.com>).Jun 28 2012, 03:09